Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCMAW-11057: Push STS test image to dev and build #338

Merged
merged 24 commits into from
Jan 24, 2025
Merged

Conversation

sandymay-dd
Copy link
Contributor

@sandymay-dd sandymay-dd commented Jan 15, 2025

What changed

Containerises the API test suite and updates the STS mock push-to-main.yml action to build/tag/publish the test image to Dev and Build.

Why did it change

This partially implements the Testing step in the Secure Pipeline methodology, whereby automated tests are run and are used to determine whether to promote the application to the next environment. The other part of the implementation will be done in the https://github.com/govuk-one-login/mobile-id-check-async-infra repository (updating the secure pipeline and test image repository Cloudformation stacks).

This is a mock asset that isn't promoted to Production; however, it is still good to run these tests so that we are alerted in case there are issues in Dev or Build that we need to address.

This also introduces a new pattern for the team - Github reusable workflows (https://docs.github.com/en/actions/sharing-automations/reusing-workflows). The intent here is to create re-usable abstracted assets helping with maintainability and improves speed of adoption for new applications. This has only been done for functionality that builds/pushes/tags the docker image used in the test containers (AWS CodeBuild)

Testing

Action successfully runs for the Dev environment. It fails for Build due to IAM policy restrictions (only the main branch can push assets to Build`; this is expected.

image

run-tests-locally.sh passes, when run against the mob-sts-mock stack

image

Checklists

  • There is a ticket raised for this PR that is present in the branch name
  • No PII data logged. See guidance here
  • Demo to a BA, TA, and the team.
  • Update README with any new instructions or tasks

@sandymay-dd sandymay-dd marked this pull request as ready for review January 16, 2025 16:27
@sandymay-dd sandymay-dd requested review from a team as code owners January 16, 2025 16:27
sts-mock/Dockerfile Outdated Show resolved Hide resolved
dothomson
dothomson previously approved these changes Jan 16, 2025
sts-mock/Dockerfile Outdated Show resolved Hide resolved
jmooney-dd
jmooney-dd previously approved these changes Jan 23, 2025
Copy link

Quality Gate Passed Quality Gate passed for 'mobile-id-check-async-sts-mock'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants