-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCMAW-11057: Push STS test image to dev and build #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandymay-dd
commented
Jan 15, 2025
sandymay-dd
commented
Jan 15, 2025
sandymay-dd
force-pushed
the
DCMAW-11057
branch
from
January 15, 2025 18:13
25dd116
to
f0bf11e
Compare
sandymay-dd
commented
Jan 15, 2025
sandymay-dd
commented
Jan 15, 2025
sandymay-dd
commented
Jan 15, 2025
sandymay-dd
force-pushed
the
DCMAW-11057
branch
from
January 15, 2025 19:08
e22659f
to
911a814
Compare
sandymay-dd
commented
Jan 16, 2025
sandymay-dd
commented
Jan 16, 2025
sandymay-dd
commented
Jan 16, 2025
sandymay-dd
commented
Jan 16, 2025
sandymay-dd
commented
Jan 16, 2025
dothomson
previously approved these changes
Jan 16, 2025
sandymay-dd
commented
Jan 17, 2025
sandymay-dd
commented
Jan 17, 2025
sandymay-dd
commented
Jan 17, 2025
jmooney-dd
reviewed
Jan 23, 2025
jmooney-dd
reviewed
Jan 23, 2025
jmooney-dd
previously approved these changes
Jan 23, 2025
Quality Gate passed for 'mobile-id-check-async-sts-mock'Issues Measures |
jmooney-dd
approved these changes
Jan 24, 2025
mthkbarber
approved these changes
Jan 24, 2025
sandymay-dd
added a commit
that referenced
this pull request
Jan 24, 2025
This reverts commit 37f63b7.
This was referenced Jan 24, 2025
sandymay-dd
added a commit
that referenced
this pull request
Jan 24, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Containerises the API test suite and updates the STS mock push-to-main.yml action to build/tag/publish the test image to Dev and Build.
Why did it change
This partially implements the Testing step in the Secure Pipeline methodology, whereby automated tests are run and are used to determine whether to promote the application to the next environment. The other part of the implementation will be done in the https://github.com/govuk-one-login/mobile-id-check-async-infra repository (updating the secure pipeline and test image repository Cloudformation stacks).
This is a mock asset that isn't promoted to Production; however, it is still good to run these tests so that we are alerted in case there are issues in Dev or Build that we need to address.
This also introduces a new pattern for the team - Github reusable workflows (https://docs.github.com/en/actions/sharing-automations/reusing-workflows). The intent here is to create re-usable abstracted assets helping with maintainability and improves speed of adoption for new applications. This has only been done for functionality that builds/pushes/tags the docker image used in the test containers (AWS CodeBuild)
Testing
Action successfully runs for the Dev environment. It fails for Build due to IAM policy restrictions (only the
main
branch can push assets to Build`; this is expected.run-tests-locally.sh passes, when run against the
mob-sts-mock
stackChecklists